Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corpus.findToken(STRING,true) fails when textContent consists only of punctuation #106

Closed
Eumaeus opened this issue Mar 1, 2018 · 2 comments
Closed

corpus.findToken(STRING,true) fails when textContent consists only of punctuation #106

Eumaeus opened this issue Mar 1, 2018 · 2 comments
Assignees
@Eumaeus
Labels
bug

Comments

@Eumaeus
Copy link
Contributor

Eumaeus commented Mar 1, 2018

E.g. a tokenized edition, where the CitableNode.text = "." and the ignorePunctuation == true, the method strips the punctuation, leaving an empty textContent, which throws an error.
@Eumaeus Eumaeus added the bug label Mar 1, 2018
@Eumaeus Eumaeus self-assigned this Mar 1, 2018
@Eumaeus
Copy link
Contributor Author

Eumaeus commented Mar 2, 2018

Made a little change and tested with one test. I'll add a few more tests and then update the version.

@Eumaeus
Copy link
Contributor Author

Eumaeus commented Mar 4, 2018

Tests added. I think this is fixed

@Eumaeus Eumaeus closed this as completed Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eumaeus Eumaeus

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eumaeus