Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corpus.nextUrn and Corpus.prevUrn don't work correctly, BUT… #103

Closed
Eumaeus opened this issue Sep 23, 2017 · 5 comments
Closed

Corpus.nextUrn and Corpus.prevUrn don't work correctly, BUT… #103

Eumaeus opened this issue Sep 23, 2017 · 5 comments
Assignees
@Eumaeus
Labels
bug

Comments

@Eumaeus
Copy link
Contributor

Eumaeus commented Sep 23, 2017

... see the pull-request. Changed ~~ to >= in prev and next functions for the Corpus object. Added tests for that in CorpusPrevNextSpec.
@Eumaeus Eumaeus added the bug label Sep 23, 2017
@Eumaeus Eumaeus self-assigned this Sep 23, 2017
@neelsmith
Copy link
Contributor

Is it possible to describe and document this in the issue tracker rather than a pull request?

@Eumaeus
Copy link
Contributor Author

Eumaeus commented Sep 23, 2017

In Corpus.scala…

Replaced ~~ with >= at lines: 663, 669, 692, and 699.

Added 6 texts in CorpusPrevNextSpec.scala.

@neelsmith
Copy link
Contributor

What is the issue, though? Anything more concrete than "not correct"?

@Eumaeus
Copy link
Contributor Author

Eumaeus commented Sep 23, 2017

Asking for corpus.prevUrn(CtsUrn("urn:cts:greekLit:tlg0012.tlg001.perseus_grc2:2.1")) returns:

Some(urn:cts:greekLit:tlg0012.tlg001.perseus_grc2:1.596-1.611)

Asking for corpus.nextUrn(CtsUrn("urn:cts:greekLit:tlg0012.tlg001.perseus_grc2:2.1")) returns:

Some(urn:cts:greekLit:tlg0012.tlg001.perseus_grc2.lemmata:2.2.1-2.4.3)

@Eumaeus
Copy link
Contributor Author

Eumaeus commented Feb 18, 2018

Fixed and tested.

@Eumaeus Eumaeus closed this as completed Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eumaeus Eumaeus

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eumaeus @neelsmith