Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CITE URNs should not have extended refs w/o versions #80

Open
Eumaeus opened this issue Jul 8, 2016 · 1 comment
Open

CITE URNs should not have extended refs w/o versions #80

Eumaeus opened this issue Jul 8, 2016 · 1 comment
Assignees

Comments

@Eumaeus
Copy link
Contributor

Eumaeus commented Jul 8, 2016

It doesn't make sense to have an extended ref on a Notional CITE Object, so we should not allow that at construction time for CITE URNs. We currently do.

I will fix that, but not until after the workshop in Kraków, this being no time to get into version-dependency hell ;-)

I have put a test in place that checks for this. It currently passes. Once I'm ready to edit the CITE code, I'll wrap it in a shouldFail { }.

@Eumaeus Eumaeus self-assigned this Jul 8, 2016
@Eumaeus
Copy link
Contributor Author

Eumaeus commented Jul 8, 2016

I will catch these in SparqlCC and reject them, for now. When we update the CITE library, those checks will become redundant, but they won't have much overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant