Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using built-in Docker Compose functionality for orchestration #156

Open
mcdonnnj opened this issue Feb 7, 2025 · 0 comments
Open
Assignees
Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented Feb 7, 2025

💡 Summary

We should look at leveraging functionality available in Docker Compose to control startup order for how we manage the order of containers running in this orchestration.

Motivation and context

We currently rely on each container writing to a redis database (running on a container) to control when containers will actually begin their functionality. We could instead leverage the service_completed_successfully condition for any containers that are simply configured to run after another has completed.

Implementation notes

This should be straightforward for the save, scan, and trustymail_report services as they all have a simple dependency relation. We would need to break out the report archiving functionality in the pshtt_report service to be able to fully do away with using redis for orchestration. I think this would also serve #151 as it would fully remove the need for container-based coordination from this configuration.

@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Feb 7, 2025
@github-project-automation github-project-automation bot moved this to To do in BOD 18-01 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Status: To do
Development

No branches or pull requests

2 participants