You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lineage should better handle the case where it has already created a pull request, but more changes are merged into the relevant skeleton.
Motivation and context
Lineage currently just blindly tacks the additional commits onto the existing pull request. This is problematic if:
The existing pull request's description does not indicate that there are conflicts
The additional commits create a conflict
Implementation notes
Lineage should at a minimum update the pull request description if the new commits generate a conflict and the existing description does not indicate that.
Even if the new commits do not generate a conflict, Lineage should possibly add a blurb to the pull request description to inform the user that additional commits were added.
Lineage probably needs to warn the user (via the PR description) if it detects that the PR has been manually modified and there are additional commits to be added. In many cases the user would want to delete the branch and let Lineage recreate it from scratch.
Acceptance criteria
How do we know when this work is done?
Criterion
The text was updated successfully, but these errors were encountered:
jsf9k
added
the
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
label
Jun 8, 2023
💡 Summary
Lineage should better handle the case where it has already created a pull request, but more changes are merged into the relevant skeleton.
Motivation and context
Lineage currently just blindly tacks the additional commits onto the existing pull request. This is problematic if:
Implementation notes
Acceptance criteria
How do we know when this work is done?
The text was updated successfully, but these errors were encountered: