From 210d0324dfa04000f385ce5688303d9015414789 Mon Sep 17 00:00:00 2001 From: Ciro Lo Sapio Date: Wed, 8 Jan 2025 11:48:10 +0100 Subject: [PATCH] bump version to 0.0.3 and update install script to include mssql-tools path --- src/alpine-php-mssql/devcontainer-feature.json | 7 ++----- src/alpine-php-mssql/install.sh | 2 ++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/alpine-php-mssql/devcontainer-feature.json b/src/alpine-php-mssql/devcontainer-feature.json index b432cbb..758bd39 100644 --- a/src/alpine-php-mssql/devcontainer-feature.json +++ b/src/alpine-php-mssql/devcontainer-feature.json @@ -1,10 +1,7 @@ { "name": "alpine-php-mssql", "id": "alpine-php-mssql", - "version": "0.0.2", + "version": "0.0.3", "description": "Installs mssql driver for php on alpine", - "documentationURL": "https://github.com/cirolosapio/devcontainers-features/tree/main/src/alpine-php-mssql", - "containerEnv": { - "PATH": "${containerEnv:PATH}:/opt/mssql-tools18/bin" - } + "documentationURL": "https://github.com/cirolosapio/devcontainers-features/tree/main/src/alpine-php-mssql" } \ No newline at end of file diff --git a/src/alpine-php-mssql/install.sh b/src/alpine-php-mssql/install.sh index f447aa2..8863c81 100644 --- a/src/alpine-php-mssql/install.sh +++ b/src/alpine-php-mssql/install.sh @@ -13,6 +13,8 @@ curl -O https://download.microsoft.com/download/3/5/5/355d7943-a338-41a7-858d-53 #Install the package(s) apk add --allow-untrusted msodbcsql18_18.3.3.1-1_amd64.apk apk add --allow-untrusted mssql-tools18_18.3.1.1-1_amd64.apk +# TODO path like this is not updated +PATH="$PATH:/opt/mssql-tools18/bin" # PHP EXTENSIONS apk --no-cache add unixodbc-dev