Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostname doesn't match expected pattern for web editor in 9.2.1 on Reverse TFT ESP32-S3 Feather #273

Open
tyeth opened this issue Dec 9, 2024 · 1 comment · May be fixed by #278
Open
Labels
bug Something isn't working

Comments

@tyeth
Copy link

tyeth commented Dec 9, 2024

CircuitPython Version

9.2.1

Workflow(s)

WEB

Browser(s)

latest chrome

Console Log

No response

Steps

Browse circuitpython.local and end up at a second device (in my setup anyway).
Notice link to reverse tft device in devices list, click link and follow.
Visit http://cpy-s3_reverse_tft-70041dce0bc4.local/ or equivalent. Click Full Code editor and end up at http://cpy-s3_reverse_tft-70041dce0bc4.local/code/
Notice interface picker (usb/ble/wifi), then picking wifi shows page not compatible with hostname error dialog.

Description

No response

Additional information

Updating this line to just check the .local suffix would maybe be safer in the long term, but it's probably just got the wrong name being generated (circuitpython repo instead):
https://github.com/circuitpython/web-editor/blob/main/js/common/utilities.js#L47

@tyeth tyeth added the bug Something isn't working label Dec 9, 2024
@tannewt
Copy link
Member

tannewt commented Dec 12, 2024

I changed the hostname to standardize it with the dhcp name in adafruit/circuitpython#9699

@tyeth tyeth closed this as completed Dec 12, 2024
@tyeth tyeth reopened this Dec 12, 2024
@Neradoc Neradoc linked a pull request Jan 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants