Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings in start-release.sh #214

Open
michi-covalent opened this issue Jun 8, 2024 · 2 comments
Open

warnings in start-release.sh #214

michi-covalent opened this issue Jun 8, 2024 · 2 comments

Comments

@michi-covalent
Copy link
Contributor

% ../release/internal/start-release.sh 1.14.11
branch 'pr/prepare-v1.14.11' set up to track 'origin/v1.14'.
Switched to a new branch 'pr/prepare-v1.14.11'
Updating VERSION, AUTHORS.md, helm templates
5ea546af5c8078a26df7fb54c0f1dd90bc365231        refs/heads/v1.14
Checking stable branch v1.12 schema version... grep: warning: stray \ before -
1.25.7
Checking stable branch v1.13 schema version... grep: warning: stray \ before -
1.26.8
Checking stable branch v1.14 schema version... grep: warning: stray \ before -
1.27.1
Checking latest branch schema version... 1.29.8
egrep: warning: egrep is obsolescent; using grep -E
| v1.14              | 1.27.1         |
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
@joestringer
Copy link
Member

I think this is going to be relying on this file in the target branch to generate the CRD schema docs, so the fix will need to into cilium/cilium and be backported:

https://github.com/cilium/cilium/blob/v1.14/Documentation/check-crd-compat-table.sh

@joestringer
Copy link
Member

Alternate solutions may include either re-evaluating the need to publish CRD schema versions in this form, or rewriting the tool in Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants