From 88507e6b223a832e4f177956f97372ea2d33f0a5 Mon Sep 17 00:00:00 2001 From: Markus Sanin Date: Mon, 8 Jan 2024 10:49:20 +0100 Subject: [PATCH] Types: Separate Args and Signature --- .../src/components/basic-dropdown.ts | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ember-basic-dropdown/src/components/basic-dropdown.ts b/ember-basic-dropdown/src/components/basic-dropdown.ts index 71094e8f..0bbcb985 100644 --- a/ember-basic-dropdown/src/components/basic-dropdown.ts +++ b/ember-basic-dropdown/src/components/basic-dropdown.ts @@ -29,8 +29,15 @@ export interface Dropdown { const UNINITIALIZED = {}; const IGNORED_STYLES = ['top', 'left', 'right', 'width', 'height']; -interface Args { +interface BasicDropdownSignature { Element: HTMLElement; + Args: BasicDropdownArgs; + Blocks: { + default: [api: Dropdown]; + }; +} + +interface BasicDropdownArgs { initiallyOpened?: boolean; renderInPlace?: boolean; verticalPosition?: string; @@ -54,9 +61,6 @@ interface Args { // eslint-disable-next-line @typescript-eslint/no-explicit-any contentComponent: string | ComponentLike; calculatePosition?: CalculatePosition; - Blocks: { - default: [api: Dropdown]; - }; } type RepositionChanges = { @@ -70,7 +74,7 @@ type RepositionChanges = { height?: string | undefined; }; -export default class BasicDropdown extends Component { +export default class BasicDropdown extends Component { @tracked hPosition: string | null = null; @tracked vPosition: string | null = null; @tracked top: string | undefined; @@ -138,7 +142,7 @@ export default class BasicDropdown extends Component { } // Lifecycle hooks - constructor(owner: Owner, args: Args) { + constructor(owner: Owner, args: BasicDropdownArgs) { super(owner, args); if (this.args.onInit) { this.args.onInit(this.publicAPI);