Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display link to Terms of Use and Privacy Policy on home page, sourced from new environment variable #484

Open
mattStorer opened this issue Oct 25, 2024 · 5 comments
Assignees
Labels
story New feature or request

Comments

@mattStorer
Copy link

MyCarePlanner needs to be updated to display a link to the Terms of Use and Privacy Policy on the home page, to resolve a VA action item identified during the demo earlier this week.

The link URL should be pulled from an environment variable that can be set by external means, similar to other REACT_APP environment variables.

I think the new environment variable should be named something along the lines of REACT_APP_TOUPP_URL, where TOUPP is an acronym for "Terms of Use and Privacy Policy".

If anything is specified in that variable, the link appears; otherwise, the link is hidden.

This is what the VA said, for reference:

Thank you for the follow-up after our demo. I am sorry I have not had a chance to send you our action list yet.

You are correct regarding the actionable items. The only one we have is providing Veterans reference links to the terms of service and privacy policy pages when logging in.

We are not picky regarding your design decision. We want to verify the links stand out and are easily viewable, so do not use blue text on a blue background.

I envision text up towards the top of the page (see image below for placement), that reads something along the lines of just "Terms of Use and Privacy Policy", made bold to stand out, per VA's request. And with appropriate margins/padding above and below the text, that empty space around it will help it pop.

image

I think that's it.

@swmuir
Copy link

swmuir commented Oct 30, 2024

image

@swmuir swmuir assigned swmuir and mattStorer and unassigned swmuir Oct 30, 2024
@swmuir swmuir added the story New feature or request label Oct 30, 2024
@mattStorer
Copy link
Author

mattStorer commented Oct 30, 2024

@swmuir thanks for adding the link to the page. It looks like this is incorporated into the exploratory branch with version 2.4.expunge20241002. Doesn't that version contain test stuff you were playing around with to see if we could get delete+expunge to work? Is that all production ready code? Shouldn't this be in version 2.4.3 instead, based off what was in 2.4.2?

@swmuir
Copy link

swmuir commented Oct 30, 2024

This was a screen shot of my local for you everyone to confirm the link met the requirement(s) if it does I will go ahead with a build

@mattStorer
Copy link
Author

@swmuir ah okay yes that context helps. I think it looks great. it sources the link from that URL environment variable, yes? presuming so, go ahead and do a build, and I'll test it here in our POC environment. thanks!

@mattStorer
Copy link
Author

@swmuir hey we're just chatting in a meeting here and discussing this topic, and the point was raised that we want to make sure that the link for these Terms of Use and Privacy Policy specify target="_blank" to ensure that the link opens in a new tab. We definitely don't want a user opening that link to open in the same tab as the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants