Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyCarePlanner - validateDOMNesting warning - <h5> cannot apear as a descendant of <p> #357

Closed
mattStorer opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
APP MyCarePlanner bug Something isn't working

Comments

@mattStorer
Copy link

Minor thing, but I wanted to log it for tracking.

It looks like MyCarePlanner's UI is trying to embed an HTML header tag within an HTML paragraph tag, which is creating some verbose warnings in the console.

Probably a super easy thing to fix.

image

@drbgfc
Copy link

drbgfc commented Mar 19, 2024

That's correct, here is the code from Home - 2 examples. Easy fix. Thanks:

            <div>
             
                <p>
                  <h5 style={{ paddingTop: '20px' }}>Shared Health Records</h5>
                  <Link to={{ pathname: '/provider-login', state: { fhirDataCollection: this.props.fhirDataCollection } }}>Retrieve records from additional healthcare providers</Link>
                </p>
             
            </div>
 

            <div>
              {typeof sdsurl !== 'undefined' ? (
                <p>
                  <h5 style={{ paddingTop: '20px' }}>Share your health data</h5>
                  <Link to={{ pathname: '/share-data' }}>Share your health data</Link></p>
              ) : (<p></p>)}
            </div>

@drbgfc
Copy link

drbgfc commented Mar 19, 2024

Note: We should be using/moving forward with MUI now anyway (typography) vs HTML elements like p h5 etc. So, suggest we do that as part of the fix. This is defintley very low priority though, as you implied. Thanks.

@kbertodatti
Copy link
Contributor

@swmuir to check code to make sure this is resolved

@kbertodatti
Copy link
Contributor

Opened a new card for the MUI typography. #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP MyCarePlanner bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants