Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_analysis needs redesigning+cleaning up to utilise plug-ins #22

Open
christuart opened this issue Aug 17, 2016 · 1 comment
Open

Comments

@christuart
Copy link
Owner

At the moment, the make_analysis method contains things which should go into plug-ins. This will make the code more clear, and also allow the user to stop them from happening from the UI, meaning that other plug-ins can augment all elements of the simulation.

E.g.
if (settings.contamination_mode_time == "constant" && settings.contamination_mode_space == "constant") { ...

This in fact isn't the only method that needs this - initialise manually checks for source sections rather than allowing interrupt_element_link_creation(...) or interrupt_pre_simulation() methods to vary the behaviour

@christuart
Copy link
Owner Author

Simulation timing is another aspect that should be moved into a plug-in. The plug-in may need to make sure that it is the last item in the 'pre-simulation' and 'post-simulation' vectors, or it may do something like checking for the 0th and (steps()-1)th steps and using those to time things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant