Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--with-wolfssl configurations is broken #574

Open
tmael opened this issue Nov 25, 2020 · 5 comments · May be fixed by #904
Open

--with-wolfssl configurations is broken #574

tmael opened this issue Nov 25, 2020 · 5 comments · May be fixed by #904

Comments

@tmael
Copy link

tmael commented Nov 25, 2020

Hi @chriskohlhoff,

A build --with-wolfssl configuration option is broken.

wolfSSL previously submitted PR #383 which has been merged into the asio mainline. Thank you!

Unfortunately, the --with-wolfssl build option hook in configure.ac was missed when cherry-picking the changes.

Can you please merge the pieces that were missed?

The workaround is to build with the following options.
./configure CPPFLAGS="-DASIO_USE_WOLFSSL" LDFLAGS="-lwolfssl"

Please let me know if you need more info or if you would like me to submit a new pull request.

Thanks,
Tesfa
@tomoveu
Copy link

tomoveu commented Dec 4, 2020

I can confirm that wolfssl option switch is broken.

asio-wolfssl-switch-broken

@tomoveu tomoveu mentioned this issue Dec 13, 2020
Closed
@tomoveu
Copy link

tomoveu commented Jan 18, 2021

Hi @chriskohlhoff could you please comment.

The original upstreaming effort was good, but the partial merge(cherry pick) caused a broken configuration.

Thanks,
Dimi

@tmael
Copy link
Author

tmael commented Mar 24, 2021

Hi Team ASIO,

This issue is blocking users of ASIO with wolfSSL building against the main-line for production releases.
Any update on this issue?
Please let me know.

Thanks,
Tesfa

@ppavlik
Copy link

ppavlik commented Sep 15, 2021

@tmael , can I suggest you create a PR for this issue to help move things along? This has been outstanding for too long.

Thanks,
Paul

dgarske added a commit to dgarske/asio that referenced this issue Sep 16, 2021
@dgarske
Fix to add wolfSSL configure support in ASIO (`./configure --with-wol…
b785c19 
…fssl=DIR`). Fixes chriskohlhoff#574
@dgarske dgarske linked a pull request Sep 16, 2021 that will close this issue
Open
@tmael
Copy link
Author

tmael commented Sep 17, 2021

@ppavlik, good idea! haven't had luck getting an email response from Chris neither. Anyway, @dgarske put up a PR to address the issue. Hoping it gets merged quickly. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to add wolfSSL configure support in ASIO dgarske/asio
3 participants
@ppavlik @tomoveu @tmael