From 0057e1076ee85528bda88bcecf36cf45e5207591 Mon Sep 17 00:00:00 2001
From: Chris Bobbe <cbobbe@zulip.com>
Date: Wed, 6 Mar 2024 16:27:49 -0800
Subject: [PATCH] settings: For subtitle of selected language, repeat canonical
 self-name
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It looks odd to have an item with:

title: 简体中文（中国）
subtitle: 中文（中国）

That's "Chinese (China)", where the first one is the canonical
self-name and the second is the name chosen by our volunteer
translators.

Better to have:

title: 简体中文（中国）
subtitle: 简体中文（中国）

The canonical self-name is what we've chosen for consistency with
other globally minded organizations, like Wikipedia.

(We could instead just omit the subtitle, but if we did, then all
the rows in the list would have two lines of text except the
selected row which would have just one. And that non-uniformity
might look odd.)
---
 src/settings/SettingsScreen.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/settings/SettingsScreen.js b/src/settings/SettingsScreen.js
index 982594a86d4..9eb1fc39044 100644
--- a/src/settings/SettingsScreen.js
+++ b/src/settings/SettingsScreen.js
@@ -135,7 +135,7 @@ export default function SettingsScreen(props: Props): Node {
         items={languages.map(l => ({
           key: l.tag,
           title: noTranslation(l.selfname),
-          subtitle: l.name,
+          subtitle: l.tag === language ? noTranslation(l.selfname) : l.name,
         }))}
         onValueChange={value => {
           dispatch(setGlobalSettings({ language: value }));