Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing grammar.js (not compiled) #1

Open
thomaswp opened this issue Oct 29, 2022 · 3 comments
Open

Missing grammar.js (not compiled) #1

thomaswp opened this issue Oct 29, 2022 · 3 comments

Comments

@thomaswp
Copy link

If you install this package, it doesn't come with the grammar.js needed to run. I had to build it manually with npx peggy node_modules/onsong/src/grammar.peggy. Makes sense you don't want to version control it, but when deploying to npm, I think it should be included.

P.S. Thanks for making this - I needed a parser and glad not to have to build my own! And it helped me find ChordBook, which is a nice alternative to a certain other website with annoying ads :D

@bkeepers
Copy link
Member

@thomaswp 👋 sorry for the very delayed response. The released package should have the grammer embedded in the generated modules in dist. Can you tell me more about how you were trying to use it and the error you are getting?

@kevinjhc
Copy link

kevinjhc commented Apr 8, 2024

@bkeepers I had the same issue, getting a Error: Cannot find module './grammar' issue when following the usage in README.

@bkeepers
Copy link
Member

bkeepers commented Apr 8, 2024

@kevinjhc ok, thanks. Can you give me more info about your environment? CJS or ESM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants