From 96e5d9856b53a066e96c89c4a97f0880bc27b32f Mon Sep 17 00:00:00 2001 From: Sprite Date: Sun, 7 Jan 2024 20:36:00 +0100 Subject: [PATCH] [binder] Fix extmodule emission --- binder/src/main/scala/PanamaCIRCTConverter.scala | 2 ++ 1 file changed, 2 insertions(+) diff --git a/binder/src/main/scala/PanamaCIRCTConverter.scala b/binder/src/main/scala/PanamaCIRCTConverter.scala index 3492e132038..edeb5ed135e 100644 --- a/binder/src/main/scala/PanamaCIRCTConverter.scala +++ b/binder/src/main/scala/PanamaCIRCTConverter.scala @@ -781,10 +781,12 @@ class PanamaCIRCTConverter extends CIRCTConverter { val builder = util .OpBuilder("firrtl.extmodule", firCtx.circuitBlock, circt.unkLoc) + .withRegionNoBlock() .withNamedAttr("sym_name", nameAttr) .withNamedAttr("sym_visibility", circt.mlirStringAttrGet("private")) .withNamedAttr("defname", nameAttr) .withNamedAttr("parameters", circt.mlirArrayAttrGet(defBlackBox.params.map(p => util.convert(p._1, p._2)).toSeq)) + .withNamedAttr("convention", circt.firrtlAttrGetConvention(FIRRTLConvention.Internal)) // TODO: handle it corretly .withNamedAttr("annotations", circt.emptyArrayAttr) val firModule = util.moduleBuilderInsertPorts(builder, ports).build()