Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance-service endpoints need to guard against requests with no projects data #55

Open
phiggins opened this issue Apr 13, 2019 · 2 comments
Labels
iamv2 This issue or pull request applies to iamv2 work for Automate

Comments

@phiggins
Copy link
Contributor

Related to chef/a2#5116

As discussed in the iamv2 meeting yesterday (4/11), for the initial implementation of projects filtering for compliance-service we are ignoring the case where incoming requests have no project data attached. By design all requests should include projects data, so this is guarding at the seams between services that this assumption is being maintained.

Being lenient to non-compliant requests is useful in the short term to allow existing code that has no knowledge of projects to continue working, but eventually we will want to be strict in how that is handled.

@vjeffrey vjeffrey added this to the iamv2: ingested nodes & actions milestone Apr 14, 2019
@vjeffrey vjeffrey added iamv2 This issue or pull request applies to iamv2 work for Automate chef-conf This issue is being targeted for delivery by chef conf labels Apr 14, 2019
@vjeffrey vjeffrey removed the chef-conf This issue is being targeted for delivery by chef conf label May 21, 2019
@lancewf
Copy link
Contributor

lancewf commented Oct 18, 2019

This needs to be done for the config-mgmt-service and the node-manager also.

@vjeffrey
Copy link

we cannot do this work until everyone is on iamv2. backing out of the sprint/board until then.

@vjeffrey vjeffrey removed this from the iamv2: ingested nodes & actions milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iamv2 This issue or pull request applies to iamv2 work for Automate
Projects
None yet
Development

No branches or pull requests

3 participants