Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decorate report for node scan in remote.go with projects information #483

Open
vjeffrey opened this issue Jun 3, 2019 · 0 comments
Open
Labels
iamv2 This issue or pull request applies to iamv2 work for Automate

Comments

@vjeffrey
Copy link

vjeffrey commented Jun 3, 2019

User Story

as part of #482, we added the projects information to the generated inspec report.
that's great for "traditional" scan jobs.
however, we also have this logic in inspec-agent/remote/remote.go that is used to build an inspec command to be executed via script. this is used for ssm/azure scans (the script is executed directly on the node).
so we need to add the projects information on the config we create here: https://github.com/chef/automate/blob/master/components/compliance-service/inspec-agent/remote/remote.go#L159
a passthrough object was introduced here: inspec/inspec#3874 -- that is how we should attach the projects information to the report

Definition of Done

node reports generated via the remote code path (ssm jobs, for example), have a projects field upon ingestion

Demo Script / Repro Steps

get an a2 instance in ec2
ensure you have a node with ssm privileges
add an aws-ec2 integration, select checkbox to read creds from the environment
select some projects and set up tags so your ssm node will have a project or two associated with it
run a scan job on your ssm node
see ingested report has projects field on it that matches projects field on ssm node

@vjeffrey vjeffrey added the iamv2 This issue or pull request applies to iamv2 work for Automate label Jun 3, 2019
@vjeffrey vjeffrey added this to the iamv2: manually added nodes and node integrations milestone Jun 3, 2019
@vjeffrey vjeffrey removed this from the iamv2: manually added nodes and node integrations milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iamv2 This issue or pull request applies to iamv2 work for Automate
Projects
None yet
Development

No branches or pull requests

1 participant