Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates due to inspec attributes to inputs change #194

Open
alexpop opened this issue Apr 4, 2019 · 1 comment
Open

Updates due to inspec attributes to inputs change #194

alexpop opened this issue Apr 4, 2019 · 1 comment
Labels
compliance ingestion This issue or pull request applies to the compliance ingestion part of Automate compliance reporting This issue or pull request applies to the compliance reporting part of Automate

Comments

@alexpop
Copy link
Contributor

alexpop commented Apr 4, 2019

For a profile with inspec.yml containing these attributes:

attributes:
  - name: bucket_name
    description: Required cloud bucket name
    type: string
    required: true
    default: 'test'

  - name: retries
    description: How many times to retry
    type: numeric
    required: false
    default: 3  

inspec json output returns both the legacy attributes array:

"attributes": [
  {
    "name": "bucket_name",
    "description": "Required cloud bucket name",
    "type": "string",
    "required": true,
    "default": "test"
  },
  {
    "name": "retries",
    "description": "How many times to retry",
    "type": "numeric",
    "required": false,
    "default": 3
  }

and the new inputs array:

"inputs": [
  {
    "name": "bucket_name",
    "options": {
      "description": "Required cloud bucket name",
      "type": "string",
      "required": true,
      "value": "test"
    }
  },
  {
    "name": "retries",
    "options": {
      "description": "How many times to retry",
      "type": "numeric",
      "required": false,
      "value": 3
    }
  }

Observed this on inspec 3.7.11 and 3.9.0.

The automate ingestion logic, elasticsearch mappings and APIs only understand the attributes array at the moment.

Will need to prioritize the backend work required by this attributes -> inputs change in inspec. It requires changes to: elasticsearch mappings, data migration, ingestion logic, API logic, reponses and UI rendering.

@skpaterson
Copy link

I'd also be interested in plans for the attributes->inputs change as it could require a lot of work in our CIS profiles.

@vjeffrey vjeffrey transferred this issue from another repository Apr 27, 2019
@vjeffrey vjeffrey added compliance ingestion This issue or pull request applies to the compliance ingestion part of Automate compliance reporting This issue or pull request applies to the compliance reporting part of Automate labels Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compliance ingestion This issue or pull request applies to the compliance ingestion part of Automate compliance reporting This issue or pull request applies to the compliance reporting part of Automate
Projects
None yet
Development

No branches or pull requests

3 participants