From a5b5985f3a44974c32ce8fc94ce7eac3220d9153 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?= =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= Date: Sat, 11 Jan 2025 07:03:38 +0530 Subject: [PATCH] sk-inet: Duplicate and free ping_group_range buffer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes the `stack-use-after-scope` error from the address sanitizer since the local variable `buffer`, goes out of scope. Signed-off-by: समीर सिंह Sameer Singh --- criu/sk-inet.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/criu/sk-inet.c b/criu/sk-inet.c index 067b171ce0..8bd5356e7b 100644 --- a/criu/sk-inet.c +++ b/criu/sk-inet.c @@ -592,7 +592,10 @@ static int do_dump_one_inet_fd(int lfd, u32 id, const struct fd_parms *p, int fa } buffer[strlen(buffer)] = '\0'; - ie.ping_grp_range = buffer; + + ie.ping_grp_range = xstrdup(buffer); + if (!ie.ping_grp_range) + goto err; } pr_info("Dumping inet socket at %d\n", p->fd); @@ -645,6 +648,7 @@ static int do_dump_one_inet_fd(int lfd, u32 id, const struct fd_parms *p, int fa xfree(ie.src_addr); xfree(ie.dst_addr); xfree(ie.ifname); + xfree(ie.ping_grp_range); return err; }