From 1781c72827d48636dacc262fdc0057f7b1582c45 Mon Sep 17 00:00:00 2001
From: Erin Hoops <109251328+ehoops-cz@users.noreply.github.com>
Date: Wed, 10 Jul 2024 11:26:07 -0700
Subject: [PATCH] fix: stop capitalizing annotation object display (#861)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Resolves #603
Resolves #860

We were capitalizing the annotation object names.  Now we're not.
<img width="1277" alt="Screenshot 2024-07-10 at 9 50 55 AM"
src="https://github.com/chanzuckerberg/cryoet-data-portal/assets/109251328/08372cef-4579-488e-adf4-729b9d07c3bc">
<img width="1278" alt="Screenshot 2024-07-10 at 9 51 04 AM"
src="https://github.com/chanzuckerberg/cryoet-data-portal/assets/109251328/4164c14a-af3b-4f26-a68d-56b9bb55a291">
<img width="1285" alt="Screenshot 2024-07-10 at 9 52 24 AM"
src="https://github.com/chanzuckerberg/cryoet-data-portal/assets/109251328/48363172-5f38-4ba2-90f9-44e04fa1218e">

The annotation filter should say "Object Name" rather than "Annotated
Object Name"
<img width="563" alt="Screenshot 2024-07-10 at 10 28 20 AM"
src="https://github.com/chanzuckerberg/cryoet-data-portal/assets/109251328/a0769e2b-60dc-4dec-90e2-94ba248c2d14">
<img width="413" alt="Screenshot 2024-07-10 at 10 28 05 AM"
src="https://github.com/chanzuckerberg/cryoet-data-portal/assets/109251328/3690aaf3-1ab3-478d-83a5-53bd00a85d59">
---
 .../data-portal/app/components/AnnotatedObjectsList.tsx      | 5 +----
 .../data-portal/app/components/Run/AnnotationTable.tsx       | 4 +---
 .../data-portal/app/components/RunFilter/RunFilter.tsx       | 2 +-
 .../packages/data-portal/e2e/singleDatasetFilter.test.ts     | 2 +-
 .../packages/data-portal/public/locales/en/translation.json  | 1 -
 5 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx b/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx
index b168e9f6a..bb81cd214 100644
--- a/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx
+++ b/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx
@@ -43,10 +43,7 @@ export function AnnotatedObjectsList({
           val1.toLowerCase().localeCompare(val2.toLocaleLowerCase()),
         )
         .map((obj) => (
-          <li
-            className="text-ellipsis line-clamp-1 break-all capitalize"
-            key={obj}
-          >
+          <li className="text-ellipsis line-clamp-1 break-all" key={obj}>
             {obj}
           </li>
         ))
diff --git a/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx b/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx
index d174cd695..2a45a344f 100644
--- a/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx
+++ b/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx
@@ -216,9 +216,7 @@ export function AnnotationTable() {
 
         cell: ({ getValue }) => (
           <TableCell width={AnnotationTableWidths.objectName}>
-            <div className="line-clamp-2 text-ellipsis capitalize">
-              {getValue()}
-            </div>
+            <div className="line-clamp-2 text-ellipsis">{getValue()}</div>
           </TableCell>
         ),
       }),
diff --git a/frontend/packages/data-portal/app/components/RunFilter/RunFilter.tsx b/frontend/packages/data-portal/app/components/RunFilter/RunFilter.tsx
index 07cbee2fd..8dbe1876e 100644
--- a/frontend/packages/data-portal/app/components/RunFilter/RunFilter.tsx
+++ b/frontend/packages/data-portal/app/components/RunFilter/RunFilter.tsx
@@ -29,7 +29,7 @@ export function RunFilter() {
       <FilterSection title={t('annotationMetadata')} border={false}>
         <AnnotatedObjectNameFilter
           allObjectNames={objectNames}
-          label={t('annotatedObjectName')}
+          label={t('objectName')}
         />
         <AnnotatedObjectShapeTypeFilter
           allObjectShapeTypes={objectShapeTypes}
diff --git a/frontend/packages/data-portal/e2e/singleDatasetFilter.test.ts b/frontend/packages/data-portal/e2e/singleDatasetFilter.test.ts
index 5e2bdece9..12018fbf2 100644
--- a/frontend/packages/data-portal/e2e/singleDatasetFilter.test.ts
+++ b/frontend/packages/data-portal/e2e/singleDatasetFilter.test.ts
@@ -13,7 +13,7 @@ testGroundTruthAnnotationFilter({
 })
 
 testSingleSelectFilter({
-  label: translations.annotatedObjectName,
+  label: translations.objectName,
   queryParam: QueryParams.ObjectName,
   url: SINGLE_DATASET_URL,
   validateTable: validateRunsTable,
diff --git a/frontend/packages/data-portal/public/locales/en/translation.json b/frontend/packages/data-portal/public/locales/en/translation.json
index da964a477..1656c7a3e 100644
--- a/frontend/packages/data-portal/public/locales/en/translation.json
+++ b/frontend/packages/data-portal/public/locales/en/translation.json
@@ -17,7 +17,6 @@
   "alignedTiltSeriesBinning": "Aligned Tilt Series Binning",
   "all": "All",
   "allDatasets": "All Datasets",
-  "annotatedObjectName": "Annotated Object Name",
   "annotatedObjects": "Annotated Objects",
   "annotationAuthor": "Annotation Author",
   "annotationAuthors": "Annotation Authors",