Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When local .npmrc is found the action still says No .npmrc file found, creating one #89

Closed
kamleshchandnani opened this issue May 4, 2021 · 8 comments

Comments

@kamleshchandnani
Copy link

Here's the repo where I have local .npmrc which is being considered but the changesets action still says.

No .npmrc file found, creating one

Here's the output message from running action

I got confused that it isn't picking up local my .npmrc even though it is. I think the messaging can be bit more contextual if it finds my local .npmrc. So I think we can change the messaging a bit.

@zthxxx
Copy link

zthxxx commented Jan 2, 2022

+1

@Andarist
Copy link
Member

Andarist commented Jan 2, 2022

@zthxxx I believe that the issue was addressed some time ago. Please take a look at my comment here. If you still believe there is an issue with the latest code then please open a new issue describing the actual and expected results.

@Andarist Andarist closed this as completed Jan 2, 2022
@zthxxx
Copy link

zthxxx commented Jan 2, 2022

Project here has the .npmrc, but in changsets/action step also say “not found”.

Action file is release.yml

@Andarist
Copy link
Member

Andarist commented Jan 2, 2022

This project has project-level .npmrc file - the log is about the lack of the user-level file.

@zthxxx
Copy link

zthxxx commented Jan 2, 2022

This project has project-level .npmrc file - the log is about the lack of the user-level file.

yes, I known that, just will make a little confused

@Andarist
Copy link
Member

Andarist commented Jan 2, 2022

How would you phrase this message to be less confusing? I'm open to suggestions.

@zthxxx
Copy link

zthxxx commented Jan 2, 2022

maybe log with prefix “user-level”?

@zthxxx
Copy link

zthxxx commented Jan 10, 2022

I believe that the issue was addressed some time ago. Please take a look at my comment here. If you still believe there is an issue with the latest code then please open a new issue describing the actual and expected results.

@Andarist I have opened a new issue #132 that relate to this issue with more deeper reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants