Enable modernized PEP-518/517 builds. #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add declarative build-system requires and build-backend via a new `pyproject.toml` sibling to the `setup.py` build. Use `pyproject.toml` `[build-system] requires` in favor of setuptools' `setup_requires`. Also update the `publish` `setup.py` command hack to use a `Pipenv` script and modern blessed build and publish tools. Fixes chakki-works#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
pyproject.toml[build-system] requiresin favor of setuptools'setup_requires.Also update the
publishsetup.pycommand hack to use aPipenvscript and modern blessed build and publish tools.
Fixes #85
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This works up until the upload step which fails, as expected, on a local build version (+XYZ).
Checklist: