Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema: Item Popup Classes incorrectly includes align-image-left #156

Closed
swashbuck opened this issue Dec 3, 2024 · 1 comment · Fixed by #157
Closed

Schema: Item Popup Classes incorrectly includes align-image-left #156

swashbuck opened this issue Dec 3, 2024 · 1 comment · Fixed by #157
Assignees
@swashbuck
Labels
bug released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Dec 3, 2024 •
edited
Loading

Subject of the issue

In the component.schema.json schema, the "Item Popup Classes" help tooltip incorrectly includes align-image-left as an option. Image alignment can only be changed now via the _imageAlignment property.

To reproduce

In the AAT, add the align-image-left class to "Item Popup Classes" and set "Image alignment" to "right". The result is that the image is right-aligned since only "Image alignment" is respected.
@swashbuck swashbuck added the bug label Dec 3, 2024
@swashbuck swashbuck self-assigned this Dec 3, 2024
@swashbuck swashbuck mentioned this issue Dec 3, 2024
Merged
swashbuck added a commit that referenced this issue Dec 4, 2024
@swashbuck
Fix: Update "Item Popup Classes" schema description to remove align c…
9e576e0 
…lass (fix #156)
github-actions bot pushed a commit that referenced this issue Dec 4, 2024
@semantic-release-bot
Chore(release): 4.6.3 [skip ci]
ed04d61 
## [4.6.3](v4.6.2...v4.6.3) (2024-12-04)

### Fix

* Update "Item Popup Classes" schema description to remove align class (fix #156) ([9e576e0](9e576e0)), closes [#156](#156)
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

🎉 This issue has been resolved in version 4.6.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck