Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileHandle.size() does not work well for large file(more than 3.9GB) #31

Open
Gabirel opened this issue Apr 9, 2020 · 2 comments
Open

FileHandle.size() does not work well for large file(more than 3.9GB) #31

Gabirel opened this issue Apr 9, 2020 · 2 comments

Comments

@Gabirel
Copy link

Gabirel commented Apr 9, 2020 •
edited
Loading

FileHandle.size() use unsigned int to return the size of the file, which only has 4,294,967,295.

Not enough for larger file.
scheibel added a commit that referenced this issue Apr 15, 2020
@scheibel
Use uintmax_t to represent file sizes (refs #31)
5ecd244
@scheibel
Copy link
Member

Thanks for pointing this out. I added a new branch with a proposed change to the interfaces and member variables.

@lppinto
Copy link

lppinto commented May 25, 2020

Is this going to be committed to master soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scheibel @lppinto @Gabirel