Suggestion #134
electrocnic
started this conversation in
General
Suggestion
#134
Replies: 2 comments
-
Second for the |
Beta Was this translation helpful? Give feedback.
0 replies
-
For example I made a commit on my branch for the implementation of the first skinning stage: linear blend skinning: da84c60 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
https://github.com/cg-tuwien/Gears-Vk/blob/11881f892a57622b3db943aee30e1350d417e9f2/framework/src/model.cpp#L984
Instead of
I suggest either using a default value for
aEndTimeTicks
, e.g.or maybe we could find some other way?
Because:
would allow users to simply call this method without providing a "huge enough" and arbitrary value for
aEndTimeTicks
, which we did in our EZG code last year:I suppose it would be a really nice opt-in to be able to define a specific
aEndTimeTicks
value, but per default users will most likely just want to play the full animation, which is anyways inferred by this method without the user needing to know the exact value from outside.Beta Was this translation helpful? Give feedback.
All reactions