Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual regression testing] Chromatic: Establish baseline snapshots #394

Open
meissadia opened this issue Jan 24, 2025 · 0 comments
Open
Assignees

Comments

@meissadia
Copy link
Contributor

meissadia commented Jan 24, 2025

  • @contolini may be the only one with the reviewer access needed to approve baseline snapshots
    • Chromatic - Unreviewed snapshots
    • My recommendation would be to accept all current snapshots as baseline and iterate/fix as needed. This would at least provide a way to catch unexpected visual changes and, since any failures in snapshot tests within the Github actions workflow are non-blocking, it would not prevent anyone from merging updates even if they don't have access to approve visual changes.
  • I think we need to re-evaluate our approach to DSR's snapshot testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant