Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apps::backup::rubrik::restapi::plugin] - custom: Token not clean and renewed #4854

Open
OlivierKuziemko opened this issue Jan 22, 2024 · 3 comments

Comments

@OlivierKuziemko
Copy link
Contributor

Hi there,

I have a issue while using rubrik plugin with token management.
The problem is located in request_api function where the token could be renewed when it expire but the cleanning/renew part is never called.
In request_api_paginate function, there is an "$self->{output}->option_exit()" called when authentication is not good and it bypass the second part of request_api function
" if (defined($self->{token}) && $self->{http}->get_code() < 200 || $self->{http}->get_code() >= 300) { ...."

To bypass the problem, I've just comment the "$self->{output}->option_exit()" and it works but it's not really clean.

@lucie-dubrunfaut
Copy link
Contributor

Hello :)

Thank you for this feedback, we have taken this token issue into account and we will keep you informed of the progress of the fix.

@brice-automatizit
Copy link

same issue here

@Evan-Adam
Copy link
Contributor

Hello @brice-automatizit , @OlivierKuziemko
Thanks again for your feedback.
I think the proper way to fix this is to quit request_api_paginate() if the server don't send back any data.
I made a pr for this : #5344
We don't have any environment available to test this. Can you check on your's if this work correctly ?

Can you also run the plugin with the option --debug and give us an anonymized version ? This will allow us to make automated test for this.

@lucie-dubrunfaut lucie-dubrunfaut changed the title [apps::backup::rubrik::restapi::plugin] Token not clean and renewed [apps::backup::rubrik::restapi::plugin] - custom: Token not clean and renewed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants