Fix #517 Configurable Docker Compose exposed ports #518
Conversation
fix path error for restAPI image
…e exposed ports
…ompose-exposed-ports Fix center-for-threat-informed-defense#517 Configurable Docker Compose exposed ports
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -3,37 +3,44 @@ services: | |||
| frontend: | |||
| container_name: attack-workbench-frontend | |||
| build: . | |||
| environment: | |||
| FRONTEND_PORT: "${FRONTEND_PORT:-80}" | |||
There was a problem hiding this comment.
Please remove all instances of setting host-centric environment variables from the environment property blocks. I believe this just includes FRONTEND_PORT and BACKEND_PORT. The rest look okay to me (since they are used by the containerized applications).
@ElJocko curious as to your thoughts.
| volumes: | ||
| - ./docker-compose-resources/nginx/nginx.conf:/etc/nginx/nginx.conf:ro | ||
|
|
||
| rest-api: | ||
| container_name: attack-workbench-rest-api | ||
| build: ../attack-workbench-rest-api | ||
| environment: | ||
| BACKEND_PORT: "${BACKEND_PORT:-3000}" |
There was a problem hiding this comment.
Please remove BACKEND_PORT.
| volumes: | ||
| - ./docker-compose-resources/nginx/nginx.conf:/etc/nginx/nginx.conf:ro | ||
|
|
||
| rest-api: | ||
| container_name: attack-workbench-rest-api | ||
| build: ../attack-workbench-rest-api | ||
| environment: | ||
| BACKEND_PORT: "${BACKEND_PORT:-3000}" | ||
| DATABASE_PORT: "${DATABASE_PORT:-27017}" |
There was a problem hiding this comment.
Please remove BACKEND_PORT and DATABASE_PORT.
|
This compose file has been superseded by the template available in the newer Workbench Deployment repo. Thank you for your contribution. |
This PR fixes #517 by allowing the use of environment variables in Docker Compose to configure the exposed ports.