From 92717ca686dc7d6ccae1ae52793eb21cb4976b51 Mon Sep 17 00:00:00 2001 From: Cem Turan Date: Sun, 19 Apr 2020 21:12:36 +0200 Subject: [PATCH] chore: allow usage of size style attrs w/o `->dp` --- package.json | 2 +- src/Post/components/ImageActions.re | 7 +++---- src/Post/components/ImageDescription.re | 2 +- src/Post/components/ImageHeader.re | 6 +++--- src/Post/components/ImageLikes.re | 4 ++-- src/Profile/Profile.re | 4 ++-- src/Profile/components/ProfileInfo.re | 4 ++-- src/components/EditButton.re | 2 +- src/components/Styled.re | 2 +- src/config/Typography.re | 2 ++ yarn.lock | 8 ++++---- 11 files changed, 22 insertions(+), 21 deletions(-) diff --git a/package.json b/package.json index b854325..39358aa 100644 --- a/package.json +++ b/package.json @@ -29,7 +29,7 @@ }, "dependencies": { "@baransu/graphql_ppx_re": "0.7.1", - "@cem2ran/ppx_style": "0.0.3", + "@cem2ran/ppx_style": "0.0.4", "@react-native-community/masked-view": "0.1.6", "@react-navigation/core": "^5.3.3", "@react-navigation/native": "^5.1.5", diff --git a/src/Post/components/ImageActions.re b/src/Post/components/ImageActions.re index f2c911e..a3ff896 100644 --- a/src/Post/components/ImageActions.re +++ b/src/Post/components/ImageActions.re @@ -6,12 +6,11 @@ let make = (~liked=true) => { style={ ViewStyle({ justifyContent: spaceBetween, - paddingHorizontal: 12.->dp, - paddingVertical: 10.->dp, + paddingHorizontal: 12., + paddingVertical: 10., }) }> - dp, justifyContent: spaceBetween})}> + - dp})}> + Option.(description or "")->React.string diff --git a/src/Post/components/ImageHeader.re b/src/Post/components/ImageHeader.re index da6552b..6b7390c 100644 --- a/src/Post/components/ImageHeader.re +++ b/src/Post/components/ImageHeader.re @@ -9,8 +9,8 @@ let make = (~image as uri, ~location, ~username) => { style={ ViewStyle({ justifyContent: spaceBetween, - paddingHorizontal: 7.->dp, - paddingVertical: 10.->dp, + paddingHorizontal: 7., + paddingVertical: 10., }) }> @@ -20,7 +20,7 @@ let make = (~image as uri, ~location, ~username) => { source=Image.(Source.fromUriSource(uriSource(~uri, ()))) /> - dp, justifyContent: center})}> + { }; dp, paddingVertical: 5.->dp})}> - dp})}> + style={ViewStyle({paddingHorizontal: 12., paddingVertical: 5.})}> + images->React.array diff --git a/src/Profile/Profile.re b/src/Profile/Profile.re index 4b56baf..c310c5d 100644 --- a/src/Profile/Profile.re +++ b/src/Profile/Profile.re @@ -38,8 +38,8 @@ let make = () => { dp, - height: 32.->dp, + width: 32., + height: 32., alignItems: center, justifyContent: center, }) diff --git a/src/Profile/components/ProfileInfo.re b/src/Profile/components/ProfileInfo.re index 670dac7..73b5b53 100644 --- a/src/Profile/components/ProfileInfo.re +++ b/src/Profile/components/ProfileInfo.re @@ -25,8 +25,8 @@ let make = (~id) => { style={ ViewStyle({ justifyContent: spaceBetween, - paddingHorizontal: 12.->dp, - paddingVertical: 12.->dp, + paddingHorizontal: 12., + paddingVertical: 12., }) }> diff --git a/src/components/EditButton.re b/src/components/EditButton.re index 19f692c..bc92e9d 100644 --- a/src/components/EditButton.re +++ b/src/components/EditButton.re @@ -7,7 +7,7 @@ let style = borderColor: "#E6E6E6", borderRadius: 4., borderWidth: 1.5, - padding: 5.->dp, + padding: 5., }) ); diff --git a/src/components/Styled.re b/src/components/Styled.re index 09453f5..b60a70e 100644 --- a/src/components/Styled.re +++ b/src/components/Styled.re @@ -118,4 +118,4 @@ module type TextT = { }, React.element, ); -}; +}; \ No newline at end of file diff --git a/src/config/Typography.re b/src/config/Typography.re index c692a70..39d5ac9 100644 --- a/src/config/Typography.re +++ b/src/config/Typography.re @@ -3,6 +3,8 @@ open ReactNative; module Edit = { include Text; + let make = Text.make; + let makeProps = Styled.text(style => style(~fontSize=13., ~fontWeight=`_700, ~color="#333", ()) diff --git a/yarn.lock b/yarn.lock index ef8a74c..823ffa5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1160,10 +1160,10 @@ resolved "https://registry.yarnpkg.com/@base2/pretty-print-object/-/pretty-print-object-1.0.0.tgz#860ce718b0b73f4009e153541faff2cb6b85d047" integrity sha512-4Th98KlMHr5+JkxfcoDT//6vY8vM+iSPrLNpHhRyLx2CFYi8e2RfqPLdpbnpo0Q5lQC5hNB79yes07zb02fvCw== -"@cem2ran/ppx_style@0.0.3": - version "0.0.3" - resolved "https://registry.yarnpkg.com/@cem2ran/ppx_style/-/ppx_style-0.0.3.tgz#db582e0b959618eefdde2601ca8c07bdce76e593" - integrity sha512-wmZji0IJJxg6JUwwQjqMDcZtCws0DiZZVfWXMA2NhYQ012nVGMbnayTr2tO1rkrH6oGrzky/vh3tcS4jOfKsHQ== +"@cem2ran/ppx_style@0.0.4": + version "0.0.4" + resolved "https://registry.yarnpkg.com/@cem2ran/ppx_style/-/ppx_style-0.0.4.tgz#c5149c089ab2797dac5589bfe08553ff949e4c5a" + integrity sha512-viw3N23Pnn1EedXWXpab9UTTmy5zePZry2jKjxr6lsmrP02bJuWrDAKJ2MjgO+EQMIMwKPvkUkIPkZZzbrxhZA== "@cnakazawa/watch@^1.0.3": version "1.0.4"