-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename message
=> blob
where applicable
#995
Comments
Also instances of celestia-app/app/process_proposal.go Lines 26 to 27 in b81723b
|
Closes celestiaorg#1022 Does not rename all instances of `message` to `blob` see celestiaorg#995
Will do this soon because it's leaking into other unrelated PRs. Unfortunately it may cause merge conflicts will several in-progress open PRs but the merge conflicts should be easy to resolve |
ADRs contain code blocks which are helpful at the time of reviewing the ADR but the code blocks have become stale so renaming portions of it to resolve this issue seems futile. We can either:
|
could we also just leave them the way they are? They might not be that useful for outside contributor or as live documentation, but they are still useful for us to remember the thinking around past decisions. |
Sure, will leave ADRs as-is for now. |
Spun out two new issues so closing this |
Closes celestiaorg/celestia-app#1022 Does not rename all instances of `message` to `blob` see celestiaorg/celestia-app#995
celestiaorg/celestia-app#995 Renames the following on a case by case basis: - `Message` => `Blob` - `message`, `msg`, `data` => `blob` Does not address: - ADRs - specs It's likely that I didn't catch every instance due to human error
Closes celestiaorg/celestia-app#1022 Does not rename all instances of `message` to `blob` see celestiaorg/celestia-app#995
celestiaorg/celestia-app#995 Renames the following on a case by case basis: - `Message` => `Blob` - `message`, `msg`, `data` => `blob` Does not address: - ADRs - specs It's likely that I didn't catch every instance due to human error
Context
#978 (comment)
Problem
The codebase currently uses the previous term
message
in a number of locations whereblob
is more accurate after #978 merged.Proposal
On a case by base basis, rename
message
,msg
, ordata
=>blob
. Note: Cosmos SDK messages should still be called messages. We should only rename instances that refer to the data a user submits to be published to the Celestia blockchain.message
=>blob
#1060message
=>blob
in ADRs #1531message
=>blob
#1532The text was updated successfully, but these errors were encountered: