TestLegacyUpgrade race detected

[rootulp]

Problem

--- FAIL: TestLegacyUpgrade (9.40s)
    --- PASS: TestLegacyUpgrade/TestIBCUpgradeFailure (3.04s)
    --- PASS: TestLegacyUpgrade/TestLegacyGovUpgradeFailure (0.03s)
    --- PASS: TestLegacyUpgrade/TestNewGovUpgradeFailure (0.02s)
=== RUN   TestRemoval
--- PASS: TestRemoval (0.06s)
=== RUN   TestSignalVersion
--- PASS: TestSignalVersion (0.00s)
=== RUN   TestTallyingLogic
--- PASS: TestTallyingLogic (0.00s)
=== RUN   TestEmptyStore
--- PASS: TestEmptyStore (0.00s)
=== RUN   TestThresholdVotingPower
--- PASS: TestThresholdVotingPower (0.00s)
=== NAME  
    testing.go:1465: race detected during execution of test
FAIL
FAIL	github.com/celestiaorg/celestia-app/x/upgrade	9.806s
testing: warning: no tests to run
PASS
ok  	github.com/celestiaorg/celestia-app/x/upgrade/cli	1.113s [no tests to run]
FAIL
make: *** [Makefile:136: test-race] Error 1
Error: Process completed with exit code 2.

Occurrences

• https://github.com/celestiaorg/celestia-app/actions/runs/7835575833/job/21381282249?pr=3089
• https://github.com/celestiaorg/celestia-app/actions/runs/7903692791/job/21572195730

Proposal

1. Short term: skip TestLegacyUpgrade when running tests in upgrade mode
2. Long term: Investigate the tests race conditions #1369