Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide and integrate the blob module with authz #1546

Open
evan-forbes opened this issue Mar 27, 2023 · 4 comments
Open

Decide and integrate the blob module with authz #1546

evan-forbes opened this issue Mar 27, 2023 · 4 comments
Labels
ADR item is directly relevant to writing or modifying an ADR consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules x/blob item is directly relevant to the blob module

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Mar 27, 2023

We are adding authz to the application in #1540, but we are pushing the integration with the blob module to a different PR. This is mainly because there are different ways to do this, each of which unblocking potential features.

We should decide on and then implement that integration. The decision might involve an ADR.

@evan-forbes evan-forbes added apphash breaking x/blob item is directly relevant to the blob module labels Mar 27, 2023
@evan-forbes evan-forbes added this to the Mainnet milestone Mar 27, 2023
@rootulp rootulp added the ADR item is directly relevant to writing or modifying an ADR label Mar 27, 2023
@liamsi
Copy link
Member

liamsi commented Mar 28, 2023

Also, everything beyond the generic authorization should be accompanied with a test.
re:

@evan-forbes evan-forbes self-assigned this May 8, 2023
@cmwaters
Copy link
Contributor

@evan-forbes Is this something we want to punt till after mainnet?

@evan-forbes
Copy link
Member Author

its less important than other things imo since we have feegrant, but if we can we should try to squeeze it in per the onsite decision.

@evan-forbes evan-forbes assigned cmwaters and unassigned evan-forbes May 15, 2023
@evan-forbes
Copy link
Member Author

to update this after a sync discussions. Since authz requires wrapping the PFB, this complicates the block encoding, specifically for zk rollups or custom parsers of the PFB namespace.

we are also able to get the same functionality using a custom feegrant interface per investigation by @cmwaters, so I'm going to remove this off of mainnet but won't close the issue.

@evan-forbes evan-forbes removed this from the Mainnet milestone May 17, 2023
@cmwaters cmwaters mentioned this issue Jun 15, 2023
21 tasks
@rootulp rootulp added consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules and removed apphash breaking labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR item is directly relevant to writing or modifying an ADR consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules x/blob item is directly relevant to the blob module
Projects
None yet
Development

No branches or pull requests

4 participants