Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the byte level unit tests for pkgs/shares #1522

Open
rootulp opened this issue Mar 22, 2023 · 0 comments
Open

Consider removing the byte level unit tests for pkgs/shares #1522

rootulp opened this issue Mar 22, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Mar 22, 2023

Context

pkg/shares currently contains many byte level unit tests for share encoding.

Problem

The unit tests are brittle and require manual updating every time we change share encoding.

Proposal

Consider isolating the byte level unit tests to the share builder. If we unit test the share builder exhaustively, then higher level abstractions (i.e. other files in pkg/shares) can test via the exposed methods on a Share rather than the raw bytes.

@rootulp rootulp added enhancement New feature or request testing items that are strictly related to adding or extending test coverage labels Mar 22, 2023
@rootulp rootulp added this to the Mainnet milestone Mar 30, 2023
@evan-forbes evan-forbes removed this from the Mainnet milestone Apr 2, 2023
@rootulp rootulp added the good first issue Good for newcomers label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

No branches or pull requests

2 participants