Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: uniformly override token denomination #1483

Open
rootulp opened this issue Mar 13, 2023 · 1 comment
Open

refactor: uniformly override token denomination #1483

rootulp opened this issue Mar 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rootulp
Copy link
Collaborator

rootulp commented Mar 13, 2023

we might want to begin thinking about how to do this in a uniform and clean way across all of the modules that we want to changes the defaults of

Originally posted by @evan-forbes in #1469 (comment)
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 13, 2023

This file contains a lot of logic to override the token denomination in various Cosmos SDK modules:

celestia-app/app/module.go

Line 88 in da2e54b

genState.Params.MintDenom = BondDenom

This issue is to refactor said overrides to something more uniform.

@rootulp rootulp added enhancement New feature or request and removed needs:triage labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp