Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic on chain start if all required parameters have not been set in genesis #1371

Open
rootulp opened this issue Feb 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rootulp
Copy link
Collaborator

rootulp commented Feb 10, 2023

Context

#1363 was caused by arabica-4's genesis.json not containing an expected parameter.

Problem

celestia-app or the cosmos-sdk doesn't verify that all required parameters have been set in genesis.json

Proposal

panic on chain start if all required parameters have not been set in genesis.json. Ideally this would be an issue and PR to cosmos-sdk. If that's not feasible, consider adding a patch to celestia-app.

@rootulp rootulp added enhancement New feature or request T:enhancement labels Feb 10, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Feb 22, 2023

We have a subcommand called validate-genesis that only performs validation for the Tendermint portion of the genesis file so this works:

$ celestia-appd validate-genesis
File at /Users/rootulp/.celestia-app/config/genesis.json is a valid genesis file

$ code /Users/rootulp/.celestia-app/config/genesis.json
// remove a necessary genesis param like per_blob_byte

$ celestia-appd validate-genesis
File at /Users/rootulp/.celestia-app/config/genesis.json is a valid genesis file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants