Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should listen on incoming signals when running in a container #1338

Open
smuu opened this issue Feb 6, 2023 · 0 comments
Open

App should listen on incoming signals when running in a container #1338

smuu opened this issue Feb 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@smuu
Copy link
Member

smuu commented Feb 6, 2023

Summary

When running celestia-app in a container I expect that it handles signals without running in a container. E.g. CTRL + C (SIGINT) for terminating the application.

Problem Definition

Better developer experience and consistency with usage.

Running the command below you can't exit the container using CTRL + C (Sends the SIGINT signal).

docker run --sig-proxy=true -v ~/.celestia-app/config/genesis.json:/opt/config/genesis.json:ro ghcr.io/celestiaorg/celestia-app:0.12.0-rc6 start

Proposal

I never worked with signal handling in go. There may be some forwarding on signals needed, probably in the Dockerfile.

@smuu smuu added the enhancement New feature or request label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant