Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture VNAMEs when converting NA to NC #61

Open
agstephens opened this issue Apr 26, 2022 · 2 comments
Open

Capture VNAMEs when converting NA to NC #61

agstephens opened this issue Apr 26, 2022 · 2 comments
Assignees

Comments

@agstephens
Copy link
Member

@FObersteiner said:

One thing that came up for me was that it might be useful (for me at least ^^) to dump VNAMEs when converting na to nc (i.e. to a global attribute maybe). The VNAMEs I have to deal with are not exactly standard and I want to provide sufficient info on those variables in the netCDF file as well (so the user doesn't have to open the na file additionally).

@agstephens said:

Do you want to propose a global attribute such as vnames_from_source_data ?

@FObersteiner said:

yes, that sounds reasonable.
Another option might be to set the original VNAME from the na file as an attribute of the xr.DataArray (make a "vname_from_source_data" tag).

@agstephens agstephens self-assigned this Apr 26, 2022
@agstephens
Copy link
Member Author

@FObersteiner: I like your idea that the xr.DataArray (i.e. the NetCDF variable) would hold the original VNAME from the NA file.

vname_from_source_data sounds good to me.

Please confirm this is still your preferred option.

@FObersteiner
Copy link
Contributor

Hi Ag, I've been busy with (mostly not data related) other stuff in the last few weeks, so I totally missed your question - sorry.

Yes, the above would still be me. Having a global attr would also be fine I guess if you see an advantage - I'll leave that to you ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants