Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to fix parameters #33

Open
drummerJim opened this issue Jul 13, 2017 · 2 comments
Open

Need to be able to fix parameters #33

drummerJim opened this issue Jul 13, 2017 · 2 comments
Labels

Comments

@drummerJim
Copy link

As a member of beamline staff I want to be able to edit the input parameters. For example, wavelength, beam centre, detector distance. I would also like to have the option of fixing these parameters. This helps to diagnose issues with the beamline. This is also useful if the header information is incorrect.

@dagewa
Copy link
Member

dagewa commented Jul 13, 2017

Currently the header information can be overridden during the dials.import step, but it would certainly be useful to have easy access to experimental geometry at any point by making the model states shown in DUI editable.

We discussed this in the DUI meeting and decided that such changes should cause a run of a command that edits the relevant .json file. This action should cause a new node to appear in the history so that the user can select the state before or after the change.

It turns out the command already exists, dials.modify_geometry :-)

@luisodls luisodls added the DUI2 label Feb 12, 2020
@dagewa
Copy link
Member

dagewa commented Feb 12, 2020

BTW parameters can be fixed during indexing and refinement, but this requires use of the advanced input tab at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants