Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want user boxr with proxy server #93

Open
SatoruUeda opened this issue Feb 21, 2020 · 2 comments
Open

I want user boxr with proxy server #93

SatoruUeda opened this issue Feb 21, 2020 · 2 comments

Comments

@SatoruUeda
Copy link

I want to use boxr via proxy server

https://github.com/cburnette/boxr/blob/master/lib/boxr.rb#L68
Would you like to be able to specify a proxy server here

https://www.rubydoc.info/gems/httpclient/HTTPClient

  BOX_CLIENT = HTTPClient.new('http://myproxy:8080')
@xhocquet
Copy link
Collaborator

Hi @SatoruUeda , thanks for reaching out.

I agree that this feature seems reasonable, useful, and within scope of how this library queries Box for resources.. If you would like to try opening a PR, I'll happily consider it! We may also need to handle user/pass for proxies since HTTPClient supports that.

In the meantime, it seems like HTTPClient can also pick up ENV vars named HTTP_PROXY or http_proxy automatically. That might allow you to use a proxy immediately without waiting for a release.

@SatoruUeda
Copy link
Author

Thank you for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants