-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate checksum before using a download file #19
Comments
@cbandy where do you want to get the cecksum from? What is the aim of checksum validation: to always have the newest file (XE changes very rarely), or to recognize cache corruption? |
Cache corruption. Any pull request (from anyone) can write anything it wants to the cache. |
According to the Travis caching docs, a pull request does not seem to threaten the cache:
Do you have other experiences? |
Oh, excellent! I agree.
I do not. You've convinced me that this issue should not block anything about caching.
This is one of the drawbacks to requiring a checksum. I'm not opposed to keeping/maintaining checksums alongside filenames in the wiki. |
Instead of putting it to the wiki, what about putting checksums in the repository, e.g. under
If you agree to this, I'll assembe a PR to do the validation. |
Consider caching and
--unless-exists
argument as well.The text was updated successfully, but these errors were encountered: