Adding Typescript Support

[chubillkelvin]

Would you consider using Typescript or add typing to support Typescript usage?

There are existing typing available in the react-rough library, plus the project uses prop-types already, so it doesn't seem too much work to add support here.

Thank you!

[cawfree]

Hey @RageBill, sorry for the delay in getting back to you. Hope this didn't cause you too much frustration.

I'd be more than happy to incorporate TypeScript support, unfortunately I'm just not right person to do it. I haven't gotten around to learning TypeScript just yet, so I'm missing the groundwork in understanding what performing a migration like this might look like.

In addition, I think if we were to add TypeScript support we'd probably need to lock down the arguments that the Rough.js generator depends upon, and have these (and their defaults) inherited across all of the components we export. It would be great to initialize these using some slightly less intensive arguments for the native runtime.

Would it be possible for you to make a new branch and add the foundation TypeScript? Like, if you port over a single component and add the compiler stage, I'll be happy to learn from that and migrate the rest over?

[chubillkelvin]

Hi @cawfree , thanks for the reply! It is completely understandable during such busy times.

I will make a pull-request for a typescript branch and see what we can do about it! I am new to this awesome library (when I saw your post on Reddit), so I might not be able to type everything. I will leave a few TODOs here and there for fixing in the future - I'll kick start it first :)

[cawfree]

@RageBill That's wicked man, thank you for understanding!

Sounds like a plan. 👍

Please don't feel obligated to do too much, I'm more than happy to build on your foundations and then just run past you for a quick sanity check.

Thanks again!

[cawfree]

#4