Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated and broken algorithms #161

Open
lacava opened this issue Nov 4, 2023 · 5 comments
Open

deprecated and broken algorithms #161

lacava opened this issue Nov 4, 2023 · 5 comments

Comments

@lacava
Copy link
Member

lacava commented Nov 4, 2023

Since PR #151 (commit 3b7181f), the following algorithms are either considered broken or deprecated:

  • gsgp (no plan to fix)
  • mrgp (no plan to fix)
  • sbp-gp (no plan to fix)
  • nsga-dcp (no plan to fix)
  • taylorgp (no plan to fix)
  • ai-feynman
  • dsr
  • uDSR
  • dagsearch (cc @kahlmeyer94)

the code for these algs should be moved to a separate branch and the authors invited to update them so that they work with the current version of the benchmark.

@kahlmeyer94
Copy link
Contributor

For dagsearch, it looked like an issue with scikit-learn. I think I fixed it now (at least it is working on my machine now).
Could you rerun the build check for dagsearch please?

Thanks :)

@lacava
Copy link
Member Author

lacava commented Nov 6, 2023

@kahlmeyer94 still failing: https://github.com/cavalab/srbench/actions/runs/6757071239/job/18403011798

@kahlmeyer94
Copy link
Contributor

kahlmeyer94 commented Nov 6, 2023

@lacava Im really confused as for where the error is. Could you help me find and fix it?
Is it because of this error message
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

or because it couldnt find torch?
Searching for torch Reading https://pypi.org/simple/torch/ Error: Process completed with exit code 1.

Edit: It looks like Pytorch is not yet available for python 3.12. (see here).
Whenever this is the case, the current version should work.
Alternatively one could use python 3.11.

@lacava
Copy link
Member Author

lacava commented Jan 18, 2024

these algs have been stored on https://github.com/cavalab/srbench/tree/deprecated-broken-algs

@filip-frisk
Copy link

FYI SJ001/AI-Feynman#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants