Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant use of recordset / allow streaming data iterators #15

Open
brendanheywood opened this issue Dec 12, 2018 · 0 comments
Open

Redundant use of recordset / allow streaming data iterators #15

brendanheywood opened this issue Dec 12, 2018 · 0 comments

Comments

@brendanheywood
Copy link
Contributor

The database source uses a recordset but then defeats the purpose by grinding through it and copying it all into an in memory array:

https://github.com/catalyst/moodle-tool_etl/blob/master/classes/source/source_database.php#L59-L66

But ultimately we need to be able to handle massive data so we need to change the API to allow extract() to return an iterator, and then each source could return a db recordset, or it could open a csv and stream through it line by line etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant