Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some place names for VCE RARE data #4007

Closed
2 tasks
Tracked by #3914
jdangerx opened this issue Jan 9, 2025 · 0 comments · Fixed by #4029
Closed
2 tasks
Tracked by #3914

Fix some place names for VCE RARE data #4007

jdangerx opened this issue Jan 9, 2025 · 0 comments · Fixed by #4029
Assignees
@krivard
Labels
internal-onboarding Good first issues, for folks who have access to all of our systems.

Comments

@jdangerx
Copy link
Member

jdangerx commented Jan 9, 2025 •
edited
Loading

Overview

The raw VCE RARE capacity factor data has each place (county/lake) as a column - we need to do some spot updates for misspellings.

Success Criteria

How will we know that we're done?

  • In the out_vcerare__hourly_available_capacity_factor table, the county_or_lake_name column only includes the name Lake Saint Clair instead of Lake St. Claire.
  • Similarly, we need to update Lake Hurron to Lake Huron

Next steps
Preview Give feedback
@jdangerx jdangerx mentioned this issue Jan 9, 2025
Open
@jdangerx jdangerx changed the title Expand "Lake St. Claire" to "Lake Saint Clare" since every other "Saint" is spelled out. Expand "Lake St. Claire" to "Lake Saint Claire" since every other "Saint" is spelled out. Jan 9, 2025
@jdangerx jdangerx changed the title Expand "Lake St. Claire" to "Lake Saint Claire" since every other "Saint" is spelled out. Expand "Lake St. Claire" to "Lake Saint Clair" since every other "Saint" is spelled out. Jan 9, 2025
@jdangerx jdangerx added the internal-onboarding Good first issues, for folks who have access to all of our systems. label Jan 9, 2025
@jdangerx jdangerx changed the title Expand "Lake St. Claire" to "Lake Saint Clair" since every other "Saint" is spelled out. Fix some place names for VCE RARE data Jan 9, 2025
@krivard krivard self-assigned this Jan 23, 2025
krivard pushed a commit that referenced this issue Jan 27, 2025
@krivard
fix: Normalize VCE RARE spellings of great lakes.
0d5e31c 
Fixes #4007
@krivard krivard mentioned this issue Jan 27, 2025
Merged
@krivard krivard moved this from New to In progress in Catalyst Megaproject Jan 27, 2025
krivard pushed a commit that referenced this issue Jan 29, 2025
Finish up release notes for #4007 fix
57d7ae7
@cmgosnell cmgosnell moved this from In progress to In review in Catalyst Megaproject Feb 3, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 7, 2025
@krivard @pre-commit-ci
fix: Normalize VCE RARE spellings of great lakes. (#4029)
18a19b7 
* fix: Normalize VCE RARE spellings of great lakes.

Fixes #4007

* Add lake_hurron and lake_st_clair to unexpected counties check

* Switch to checking row counts by report year instead of by job name

* Finish up release notes for #4007 fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

For more information, see https://pre-commit.ci

---------

Co-authored-by: Kathryn Mazaitis <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In review to Done in Catalyst Megaproject Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krivard krivard

Labels
internal-onboarding Good first issues, for folks who have access to all of our systems.
Projects
Catalyst Megaproject
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Normalize VCE RARE spellings of great lakes. catalyst-cooperative/pudl
2 participants
@krivard @jdangerx