Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Release failure #5

Closed
NobodyXu opened this issue Feb 7, 2024 · 4 comments
Closed

CI: Release failure #5

NobodyXu opened this issue Feb 7, 2024 · 4 comments

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Feb 7, 2024

https://github.com/cargo-bins/simple-git/actions/runs/7811061913

release-pr fails to find any crate within the repository, which is quite strange.

@passcod Do I have to provide a path to the crate explicitly?

@passcod
Copy link
Member

passcod commented Feb 7, 2024

It's expecting a format it's not finding in the cargo metadata: https://github.com/cargo-bins/release-pr/blob/main/src/main.ts#L566

Not sure why, logs are:

2024-02-07T06:57:44.4937513Z only one crate in workspace, assuming that is it
2024-02-07T06:57:44.4962968Z ##[warning]could not parse package format: "path+file:///home/runner/work/simple-git/simple-git#0.2.2", skipping
2024-02-07T06:57:44.4972522Z ##[error]No crates found at the root, try specifying crate-name, crate-path, or crate-release-all.
2024-02-07T06:57:44.4974090Z ##[error]no good crate found

But also we should try https://release-plz.ieni.dev it's kinda like the supercharged semi-automated version of our release workflow

@NobodyXu
Copy link
Member Author

NobodyXu commented Feb 9, 2024

Ok I decides I will release it manually

@passcod
Copy link
Member

passcod commented Feb 10, 2024

Tbh releasing manually is perfectly fine for these smaller crates. I do manual releases for a bunch of things where it's not worth adding full-fledged release workflows :)

@NobodyXu
Copy link
Member Author

Yeah, I'd probably remove the release CI

@NobodyXu NobodyXu closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants