From 94bc36fd9864718ce8c1201b04b0e018e3d80f6d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20OLIVIER?= <clement.olivier@javista.com>
Date: Mon, 30 Nov 2020 21:00:10 +0100
Subject: [PATCH 1/6] #77 getting label from form definition instead of entity
 definition

---
 QuickEditForm/QuickEditForm/index.ts | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/QuickEditForm/QuickEditForm/index.ts b/QuickEditForm/QuickEditForm/index.ts
index 4a631ba..bbc622a 100644
--- a/QuickEditForm/QuickEditForm/index.ts
+++ b/QuickEditForm/QuickEditForm/index.ts
@@ -665,8 +665,15 @@ export class QuickEditForm implements ComponentFramework.StandardControl<IInputs
 						fieldDetail = fieldDetail[0];
 					}
 
+					// @ts-ignore
+					var labelName =  $.parseXML(row).getElementsByTagName("label")[0].attributes.description?.value;
+
+					if(labelName == null){
+						labelName = fieldDetail.DisplayName;
+					}
+
 					// Generating the fields rendering
-					this.retrieveFieldOptions(fieldDetail, isReadOnly, subColumnDiv);	
+					this.retrieveFieldOptions(fieldDetail, isReadOnly, labelName, subColumnDiv);	
 				}
 			}
 		}
@@ -676,13 +683,13 @@ export class QuickEditForm implements ComponentFramework.StandardControl<IInputs
 	 * Render the fields based on the metatada
 	 * @param fieldDetail field metadata
 	 */
-	private retrieveFieldOptions(fieldDetail: any, fieldReadOnly : boolean, divflex : HTMLDivElement){
+	private retrieveFieldOptions(fieldDetail: any, fieldReadOnly : boolean, labelName : string, divflex : HTMLDivElement){
 		let _this = this;
 		let item = document.createElement("div");
 		var techFieldName = fieldDetail.attributeDescriptor.LogicalName;
 		var controlId = "carfup_qef_"+techFieldName;
 		var type = fieldDetail.attributeDescriptor.Type;
-		var label = fieldDetail.DisplayName;
+		var label = labelName;
 
 		let isReadOnly = !fieldDetail.attributeDescriptor.IsValidForUpdate || this._isRecordReadOnly || fieldReadOnly || this._context.mode.isControlDisabled;
 		let isRequired = fieldDetail.attributeDescriptor.RequiredLevel == 1 || fieldDetail.attributeDescriptor.RequiredLevel == 2;

From c0db1ee2ff6e5d47fe78f6c3bd0a402c4dee3aae Mon Sep 17 00:00:00 2001
From: Aldo Garcia <aldo_garcia@navyfederal.org>
Date: Fri, 4 Dec 2020 18:22:44 +0000
Subject: [PATCH 2/6] Adding hidden field feature

---
 QuickEditForm/QuickEditForm/index.ts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/QuickEditForm/QuickEditForm/index.ts b/QuickEditForm/QuickEditForm/index.ts
index 4a631ba..36cbcee 100644
--- a/QuickEditForm/QuickEditForm/index.ts
+++ b/QuickEditForm/QuickEditForm/index.ts
@@ -650,6 +650,13 @@ export class QuickEditForm implements ComponentFramework.StandardControl<IInputs
 						continue;
 					}
 
+					//@ts-ignore
+					let isHidden = $.parseXML(row).getElementsByTagName("cell")[0].attributes?.visible?.value === "false";
+
+					if (isHidden) {
+						continue;
+					}
+
 					// @ts-ignore
 					var rowTechName =  $.parseXML(row).getElementsByTagName("control")[0].attributes.datafieldname.value;
 					// @ts-ignore

From 21a99f7c869457e2268d6ef3367088fb5ce1e1c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20OLIVIER?= <clement.olivier@javista.com>
Date: Mon, 4 Jan 2021 21:12:01 +0100
Subject: [PATCH 3/6] using proper label for field (form & not entity)

---
 QuickEditForm/QuickEditForm/index.ts | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/QuickEditForm/QuickEditForm/index.ts b/QuickEditForm/QuickEditForm/index.ts
index a71d1ad..3131e38 100644
--- a/QuickEditForm/QuickEditForm/index.ts
+++ b/QuickEditForm/QuickEditForm/index.ts
@@ -645,15 +645,11 @@ export class QuickEditForm implements ComponentFramework.StandardControl<IInputs
 				for(j = numberOfRowPerColumn * k; j < nextColumnCount; j++)
 				{
 					let row = rows[j].outerHTML;
-					// @ts-ignore
-					if($.parseXML(row).getElementsByTagName("control").length == 0 || $.parseXML(row).getElementsByTagName("label").length == 0 || $.parseXML(row).getElementsByTagName("control")[0].attributes.datafieldname == undefined || $.parseXML(row).getElementsByTagName("label")[0].attributes.description == undefined){
-						continue;
-					}
-
 					//@ts-ignore
 					let isHidden = $.parseXML(row).getElementsByTagName("cell")[0].attributes?.visible?.value === "false";
-
-					if (isHidden) {
+					
+					// @ts-ignore
+					if($.parseXML(row).getElementsByTagName("control").length == 0 || $.parseXML(row).getElementsByTagName("label").length == 0 || $.parseXML(row).getElementsByTagName("control")[0].attributes.datafieldname == undefined || $.parseXML(row).getElementsByTagName("label")[0].attributes.description == undefined || isHidden){
 						continue;
 					}
 

From 1c1e71af2cb06a9c35fd4964f3e3b0a86ffdcd15 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20OLIVIER?= <clement.olivier@javista.com>
Date: Mon, 4 Jan 2021 21:12:27 +0100
Subject: [PATCH 4/6] remove the autoadjustheigth to display scrollbar on
 multiline

---
 QuickEditForm/QuickEditForm/components/TextFieldControl.tsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx b/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx
index b84582a..93e45f4 100644
--- a/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx
+++ b/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx
@@ -49,7 +49,6 @@ export default class TextFieldControl extends React.Component<ITextFieldControlP
                         value={this.grabValueFromFieldDefinition()} 
                         id={this.props.fieldDefinition.controlId} 
                         multiline={(this.props.fieldDefinition?.fieldType == "memo")}
-                        autoAdjustHeight={(this.props.fieldDefinition?.fieldType == "memo")}
                         type={this.state.type}
                         iconProps={{ iconName: this.props.icon }} 
                         onClick={this.onClick} 

From dd0ff622bb2d15014004d7901a3ca343814bb315 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20OLIVIER?= <clement.olivier@javista.com>
Date: Mon, 4 Jan 2021 21:19:28 +0100
Subject: [PATCH 5/6] switched rows from 3 to 4 for mutlilines

---
 QuickEditForm/QuickEditForm/components/TextFieldControl.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx b/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx
index 93e45f4..f518b8b 100644
--- a/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx
+++ b/QuickEditForm/QuickEditForm/components/TextFieldControl.tsx
@@ -53,6 +53,7 @@ export default class TextFieldControl extends React.Component<ITextFieldControlP
                         iconProps={{ iconName: this.props.icon }} 
                         onClick={this.onClick} 
                         style={{width:"100%"}}
+                        rows={(this.props.fieldDefinition?.fieldType == "memo" ? 4 : 1)}
                         onDoubleClick={this.onDoubleClick}
                         onChange={this.onChange}
                         onFocus={(event) => {

From 8ffd13e3d7417dcb99eb27fc6dbd4f4c06598120 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20OLIVIER?= <clement.olivier@javista.com>
Date: Mon, 4 Jan 2021 21:20:15 +0100
Subject: [PATCH 6/6] versions updates

---
 Carfup_PCFControls/Other/Solution.xml                 | 2 +-
 QuickEditForm/QuickEditForm/ControlManifest.Input.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Carfup_PCFControls/Other/Solution.xml b/Carfup_PCFControls/Other/Solution.xml
index c4113af..c4df9d6 100644
--- a/Carfup_PCFControls/Other/Solution.xml
+++ b/Carfup_PCFControls/Other/Solution.xml
@@ -8,7 +8,7 @@
       <LocalizedName description="Carfup_PCFControls" languagecode="1033" />
     </LocalizedNames>
     <Descriptions />
-    <Version>1.3.3.1</Version>
+    <Version>1.3.3.2</Version>
     <!-- Solution Package Type: Unmanaged(0)/Managed(1)/Both(2)-->
     <Managed>2</Managed>
     <Publisher>
diff --git a/QuickEditForm/QuickEditForm/ControlManifest.Input.xml b/QuickEditForm/QuickEditForm/ControlManifest.Input.xml
index e738a71..0cddbd1 100644
--- a/QuickEditForm/QuickEditForm/ControlManifest.Input.xml
+++ b/QuickEditForm/QuickEditForm/ControlManifest.Input.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest>
-  <control namespace="Carfup" constructor="QuickEditForm" version="0.0.240" display-name-key="Carfup.QuickEditForm" description-key="QuickEditForm allows you to edit data from a lookup record using a Quick View Form definition as enty form." control-type="standard" preview-image="img/preview.png">
+  <control namespace="Carfup" constructor="QuickEditForm" version="0.0.241" display-name-key="Carfup.QuickEditForm" description-key="QuickEditForm allows you to edit data from a lookup record using a Quick View Form definition as enty form." control-type="standard" preview-image="img/preview.png">
     <!-- property node identifies a specific, configurable piece of data that the control expects from CDS -->
     <property name="FieldToAttachControl" display-name-key="FieldToAttachControl" description-key="Property_Desc_Key" of-type="SingleLine.Text" usage="bound" required="true" />
     <property name="QuickViewFormId" display-name-key="QuickViewFormId" description-key="GUID of the Quick View Form to render" of-type="SingleLine.Text" usage="input" required="true" />