CIP-0108 | Ensure "CIP-0008" is in capital letters

[palas]

This PR addresses the issue #949, by ensuring CIP-0008 is used in capital letters in the witnessAlgorithm field of the witness type in CIP-0108, updating the "no-confidence" example and the test vector Markdown documentation.

Fixes #949.

[rphair]

Can't think of any technical things that would fail because of this schema change but please @Ryun1 @Crypto2099 @perturbing @gitmachtl confirm if you can.

[Ryun1]

Great spot @palas
ill reach out to tooling to double check that this change wouldnt break their implementations before we merge

[Ryun1]

I pushed this update, because of the change introduced in no-confidence example changed the hash digest

[Ryun1]

Spoke to a couple implementors, this change is all good to go.
Fortunately because governance actions are very expensive on mainnet, there isnt any examples of this on mainnet

[Ryun1]

Thanks @palas 💪

[gitmachtl]

Why do we use the public key for CIP-0008 method here and not the Cose_Key?

Is there a written definition on the parameters used for this signature? Because CIP0008 allows for different ones. I guess we're going with the

  kty (1) - must be set to OKP (1)
  kid (2) - Optional, if present must be set to the same value as in the Sig_structures protectedHeader_cbor via map entry (4)
  alg (3) - must be set to EdDSA (-8)
  crv (-1) - must be set to Ed25519 (6)
  x (-2) - must be set to the public key bytes of the key used to sign the Sig_structure

one?

If so, that should be specified in CIP108 too imo. @Ryun1 ?

[Ryun1]

@gitmachtl
the motivation for this inclusion in CIP8 is so that these signatures can be created over CIP30 connections, so using light wallets

[gitmachtl]

@Ryun1 yes adding CIP8 is totally fine! i am refering that there should be more detailed information in the CIP about which parameters should be used with CIP8. and normally we have a COSE_Sign1 signature cbor-structure/hex and a corresponding COSE_Key cbor-structure/hex, not only the publickey. for verification we need the parameters set as above, otherwise it would fail. but that information should be in the description of the CIPs imo. or we switch to use the COSE_Key in the publickey field of the signatures?

[gitmachtl]

@Ryun1 @palas the example file
https://github.com/cardano-foundation/CIPs/blob/72d499ffa0d6116c41b46276946bb5dc03f53165/CIP-0108/examples/no-confidence.jsonld
is missing the name field for the author