-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding awesome-linters to the main awesome
repository
#28
Comments
awesome
repository
Hello, I'm sorry for the delay in the response. I wanted to think about it for a bit first before answering. I started this list a long time ago just for me and some friends to have so point of reference for cool linters to use but after a while any problem must evolve and as I see more people contributing and staring it I understand that it has some purpose for other people also. With that said, I think it'd be cool if we could get into that list but those rules might be hard to follow, let's tackle them:
In that spirit I created issues #29, #30 and #31. These should be completed before we close this issue. Also, I don't think the image preposition is reasonable, I don't understand how it contributes to the project as a whole and also I have no design or imaging skills. It would just be a waste of time. How does that sound to you? EDIT: If you feel like working on any of the specific issues, let me know and I'll asign it to you. 😄 |
Hey Hugo, You can assign me the #29 then. 😃 (no need to apologize for the delay) |
I see that you were able to assign it to yourself @mlcdf. Cool 👍 |
Yep, thanks for adding me as a collaborator! |
#30 has now been closed fixing the description in the items issue. |
Seems like this one is done now. Would you like to try and make the PR @mlcdf ? |
Sure! |
Cool. I think you can close the issue when the PR is created. Either it gets accepted or it won't. 😄 Thank you for the effort! 👍 |
Here the PR: sindresorhus/awesome#858 Good work! 👍 |
sindresorhus made a comment on the PR:
His point is valid and I had not thought about it. I'm pretty busy right now (it's the end of the semester), but I'll have some free time in February to do this. :) |
His point is valid but misguided. I don't feel this is an issue and should not be treated as one. This list was not made with the goal of inserting it into sindresorhus/awesome. It was made to be useful for me as a repository for linting information and other people for the same reason. As a suggestion this would be a good thing but as far as I'm concerned we should not be pushing to find random stuff to put here on this topic just so we can get into his project. This is a collection of useful information - we shouldn't be searching for it simply just to be part of that repository. He made a suggestion and that is as valid as anything but he's coming from his own perspective, his own community and his feelings towards the use he could give to the list which isn't remotely connected to what the people that read this list feel. He's not looking at it from the perspective of the few people that look at this and think "this is a cool resource, I'm going to save it". In this sense, if people find it useful to just have linters. Why wouldn't it just have linters? I have no problem with the pull request being rejected on the grounds that he doesn't find the list useful but we won't try to push everything we can find in here just so we can make it on the list. I'll actually rather be rejected than do more of that like we did to get the list on a state that it could be made into a PR. Now with this being said, I have no issue with expanding the project towards all those fields he mentioned but honestly, I won't do it to be part of his repository. We'll do it incrementally instead of just to be part of his repository. What do you think @mlcdf? |
Yeah you're right. I mean, I really like his (Sindre's) idea of expending the scope of this list and also including others resources in order to help people that aren't already familiar with linters. But, like you said, we shouldn't do this just to get into the Oh and yeah, this is totally not an issue. I just didn't thought of another way to get in touch with you. |
Cool. Since we agree @mlcdf, I'm going to close both issues. In the near feature (next week probably) I'll extend the scope of the project in the README.md. Thanks! |
(following PR #27)
I went looking at some PR on sindresorhus/awesome and I stumbled upon this:
By submitting this pull request I confirm I've read and complied with the below requirements.
Failure to properly do so will just result in the pull request being closed and everyone's time wasted. Please read it twice. Most people miss many things.
Add Name of List
, notUpdate readme.md
orAdd awesome list
.Contents
as the first section,A
/An
prefixes in the descriptions.Node.js
, notNodeJS
ornode.js
.In order to be listed in the
awesome
repo, we would need to add a little description for each items. Does this sounds good to you?The text was updated successfully, but these errors were encountered: