From 43c461da82e5202bb53fb9add8c0755c71403285 Mon Sep 17 00:00:00 2001 From: Ben Pennell Date: Wed, 16 Oct 2024 14:05:11 -0400 Subject: [PATCH] Use a try-with-resource block when getting the stream of files in derivative directory to avoid file handle leak --- .../illinois/library/cantaloupe/cache/FilesystemCache.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/edu/illinois/library/cantaloupe/cache/FilesystemCache.java b/src/main/java/edu/illinois/library/cantaloupe/cache/FilesystemCache.java index ab0dc383a..7b1397ddb 100644 --- a/src/main/java/edu/illinois/library/cantaloupe/cache/FilesystemCache.java +++ b/src/main/java/edu/illinois/library/cantaloupe/cache/FilesystemCache.java @@ -508,8 +508,8 @@ Set getDerivativeImageFiles(Identifier identifier) hashedPathFragment(identifier.toString())); final String expectedNamePrefix = StringUtils.md5(identifier.toString()); - try { - return Files.list(cachePath) + try (final var fileStream = Files.list(cachePath)) { + return fileStream .filter(p -> p.getFileName().toString().startsWith(expectedNamePrefix)) .collect(Collectors.toUnmodifiableSet()); } catch (NoSuchFileException e) {